Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Relax comparison of floats in tests#818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

bnavigator
Copy link
Contributor

While trying tofixpython-control/Slycot#187 inpython-control/Slycot#188, I ran into precision related errors of the control test suite. Seems like the new NumPy moves around some libraries affecting the floats.

There are more errors related to the frequency vector calculation of FRDs, which need to be investigated.

@bnavigatorbnavigator changed the titleEasy comparison of floats in testsRelax comparison of floats in testsDec 18, 2022
@coveralls
Copy link

coveralls commentedDec 18, 2022•
edited
Loading

Coverage Status

Coverage decreased (-0.01%) to 94.803% when pulling5352222 on bnavigator:flatsys-float-tests into2f343be on python-control:main.

@murrayrm
Copy link
Member

Odd that we are still seeing the FRD error and that this only happens in the slycot from source version.

@murrayrm
Copy link
Member

I'm seeing some problems inmy own copy of this branch. It looks like usingnulps is the source of the problems, but it doesn't happen on all builds. ???

@murrayrm
Copy link
Member

It looks like the problem in the FRD tests had to do with usingnp.linspace to generate the list of frequencies and then specifying a subset of frequencies for testing "manually". Picking the frequencies out from the original list seems to have fixed the problem.

@bnavigator
Copy link
ContributorAuthor

Thank you!

@bnavigatorbnavigator merged commit56f227f intopython-control:mainDec 21, 2022
@murrayrmmurrayrm added this to the0.9.3 milestoneDec 24, 2022
@bnavigatorbnavigator deleted the flatsys-float-tests branchFebruary 18, 2024 20:30
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.9.3
Development

Successfully merging this pull request may close these issues.

Numpy 1.24 breaks compiling Slycot
3 participants
@bnavigator@coveralls@murrayrm
[8]ページ先頭
©2009-2025 Movatter.jp