NotificationsYou must be signed in to change notification settings
Fork441
Star1.8k

add zpk() function#816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

murrayrm merged 2 commits intopython-control:mainfrommurrayrm:zpk-13Dec2022

Dec 17, 2022

Merged

add zpk() function#816

murrayrm merged 2 commits intopython-control:mainfrommurrayrm:zpk-13Dec2022

Dec 17, 2022

Conversation

Copy link

Member

murrayrm commentedDec 16, 2022•
edited
Loading

This PR adds the functionzpk, which creates a transfer function (as aNamedIOSystem) from a zero, pole, gain representation. This responds to issue#749.

Also added in code to make sure that signal names are copied correctly in various conversions, removing some comments entered in PR#804. In_convert_to_transfer_function this involved removing renaming from the low level function, as documented in the comment string.

Notes:

Unlike in MATLAB and SciPy, which have zpk classes, here we just create a transfer function from the zpk data. That seems like the most common use case.
In thematlab module there are also functionszpk2ss andzpk2tf that implement lower level behavior (eg, zpk2ss returns A, B, C, D). This is similar to MATLAB. if you want to get aStateSpace system from a zpk representation, usesys = ct.ss(ct.zpk(zeros, poles, gain)).
Unit tests and updated documentation are also included.