- Notifications
You must be signed in to change notification settings - Fork441
Update docstring for impulse for discrete sys#812
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Update impulse_response doc string to indicate that the impulse size is unit area for discrete systems.
murrayrm commentedDec 11, 2022 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
We definitely need to update the documentation, but I wonder whether we shouldn't also consider what the right definition of the impulse response is for a discrete time system with non-unit sampling time. |
I made this change a little while back to match what matlab does, which is a unit-area impulse for discrete-time systems:https://www.mathworks.com/help/control/ref/lti.impulse.html. This arrangement is probably what you want if you are viewing a discrete-time system as a discretized model of a continuous-time system. Probably unit area is favored by engineering, unit magnitude by math. Probably a subjective choice. Anybody here have further insight into such a choice? |
ilayn commentedDec 12, 2022 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
As the sampling You can test it yourself by generating a [1, 0, 0, 0, ...] array and supply to |
@ilayn's comment makes it clear why scaling by the sampling time is the right approach (and I was mistaken about what MATLAB does). |
Update impulse_response doc string to indicate that the impulse size is unit area for discrete systems.