- Notifications
You must be signed in to change notification settings - Fork441
docstring improvements#804
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Merged
Changes fromall commits
Commits
Show all changes
6 commits Select commitHold shift + click to select a range
3a554b5
docstring fixes: standardize description for lyap and care to be cons…
sawyerbfuller11d9350
a few more fixes to sys.sample
sawyerbfullerbf50ded
mention lqe and dlqe in matlab module, reorder so that eg lqr and dlq…
sawyerbfuller2311a4d
bring back 'Other parameters' in docstrings, alphabetize TOC
sawyerbfuller7acd3fc
added signature for drss, import missing stochsys for matlab module, …
sawyerbfuller16457d7
explicit import of stochsys in matlab, per @bnavigator
murrayrmFile filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
There are no files selected for viewing
6 changes: 3 additions & 3 deletionscontrol/dtime.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
18 changes: 10 additions & 8 deletionscontrol/iosys.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -2210,17 +2210,16 @@ def linearize(sys, xeq, ueq=None, t=0, params=None, **kw): | ||
The linearization of the system, as a :class:`~control.LinearIOSystem` | ||
object (which is also a :class:`~control.StateSpace` object. | ||
sawyerbfuller marked this conversation as resolved. Show resolvedHide resolvedUh oh!There was an error while loading.Please reload this page. | ||
Other Parameters | ||
---------------- | ||
inputs : int, list of str or None, optional | ||
Description of the system inputs. If not specified, the origional | ||
system inputs are used. See :class:`InputOutputSystem` for more | ||
information. | ||
outputs : int, list of str or None, optional | ||
Description of the system outputs. Same format as `inputs`. | ||
states : int, list of str, or None, optional | ||
Description of the system states. Same format as `inputs`. | ||
""" | ||
if not isinstance(sys, InputOutputSystem): | ||
raise TypeError("Can only linearize InputOutputSystem types") | ||
@@ -2429,7 +2428,10 @@ def rss(states=1, outputs=1, inputs=1, strictly_proper=False, **kwargs): | ||
def drss(*args, **kwargs): | ||
""" | ||
drss([states, outputs, inputs, strictly_proper]) | ||
Create a stable, discrete-time, random state space system | ||
Create a stable *discrete time* random state space object. This | ||
function calls :func:`rss` using either the `dt` keyword provided by | ||
@@ -2467,7 +2469,7 @@ def ss2io(*args, **kwargs): | ||
# Convert a transfer function into an input/output system (wrapper) | ||
def tf2io(*args, **kwargs): | ||
"""tf2io(sys[, ...]) | ||
Convert a transfer function into an I/O system | ||
@@ -2716,8 +2718,8 @@ def interconnect(syslist, connections=None, inplist=None, outlist=None, | ||
:func:`~control.summing_block` function and the ability to automatically | ||
interconnect signals with the same names: | ||
>>> P = control.tf(1, [1, 0], inputs='u', outputs='y') | ||
>>> C = control.tf(10, [1, 1], inputs='e', outputs='u') | ||
>>> sumblk = control.summing_junction(inputs=['r', '-y'], output='e') | ||
>>> T = control.interconnect([P, C, sumblk], inputs='r', outputs='y') | ||
17 changes: 12 additions & 5 deletionscontrol/mateqn.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
1 change: 1 addition & 0 deletionscontrol/matlab/__init__.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
38 changes: 5 additions & 33 deletionscontrol/matlab/timeresp.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
3 changes: 1 addition & 2 deletionscontrol/matlab/wrappers.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
8 changes: 4 additions & 4 deletionscontrol/sisotool.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
7 changes: 4 additions & 3 deletionscontrol/statesp.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -807,7 +807,7 @@ def __rdiv__(self, other): | ||
"StateSpace.__rdiv__ is not implemented yet.") | ||
def __call__(self, x, squeeze=None, warn_infinite=True): | ||
"""Evaluate system'sfrequency response at complexfrequencies. | ||
Returns the complex frequency response `sys(x)` where `x` is `s` for | ||
continuous-time systems and `z` for discrete-time systems. | ||
@@ -1344,8 +1344,8 @@ def sample(self, Ts, method='zoh', alpha=None, prewarp_frequency=None, | ||
sysd : StateSpace | ||
Discrete-time system, with sampling rate Ts | ||
sawyerbfuller marked this conversation as resolved. Show resolvedHide resolvedUh oh!There was an error while loading.Please reload this page. | ||
Other Parameters | ||
---------------- | ||
inputs : int, list of str or None, optional | ||
Description of the system inputs. If not specified, the origional | ||
system inputs are used. See :class:`InputOutputSystem` for more | ||
@@ -1520,6 +1520,7 @@ def output(self, t, x, u=None, params=None): | ||
# TODO: add discrete time check | ||
# TODO: copy signal names | ||
def _convert_to_statespace(sys): | ||
"""Convert a system to state space form (if needed). | ||
8 changes: 4 additions & 4 deletionscontrol/xferfcn.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1136,11 +1136,11 @@ def sample(self, Ts, method='zoh', alpha=None, prewarp_frequency=None, | ||
sysd : TransferFunction system | ||
Discrete-time system, with sample period Ts | ||
sawyerbfuller marked this conversation as resolved. Show resolvedHide resolvedUh oh!There was an error while loading.Please reload this page. | ||
Other Parameters | ||
---------------- | ||
inputs : int, list of str or None, optional | ||
Description of the system inputs. If not specified, the origional | ||
system inputs are used. See :class:`InputOutputSystem` for more | ||
information. | ||
outputs : int, list of str or None, optional | ||
Description of the system outputs. Same format as `inputs`. | ||
@@ -1585,7 +1585,7 @@ def tf(*args, **kwargs): | ||
else: | ||
raise ValueError("Needs 1 or 2 arguments; received %i." % len(args)) | ||
# TODO: copy signal names | ||
def ss2tf(*args, **kwargs): | ||
"""ss2tf(sys) | ||
Oops, something went wrong.
Uh oh!
There was an error while loading.Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.