- Notifications
You must be signed in to change notification settings - Fork441
Preserve signal names upon conversion to discrete-time#797
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
coveralls commentedNov 23, 2022 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
I suggest following the conventions used in
Doing this for Also, we might want to override the |
… namedio, update sys.sample to enable signal names to be passed.
sawyerbfuller commentedNov 23, 2022 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
@murrayrm thanks for the pointer. I refactored the code used in Questions:
|
I like the revisions and pretty much agree with them all, especially moving the functionality up to namedio.py (which is where it belongs). Some additional thoughts:
|
…m and unit tests, namedio.copy is now deepcopy
Great. New commit:
Following@murrayrm's comment above:
|
This all looks good to me. Will let it sit for another day or two just in case someone else wants to take a look, but I think it is ready to merge. |
This PR updates
sys.sample
in bothStateSpace
andTransferFunction
to return a system with the same input and output labels, which is convenient when constructing interconnected systems usinginterconnect
.The changes in this PR only copy signal names, but the name of the system is not preserved. I haven't used the system name feature before but my impression was that it should be unique, but please let me know if you think it should be passed as well.