NotificationsYou must be signed in to change notification settings
Fork441
Star1.8k

fix _isstatic() to use nstates==0#790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

sawyerbfuller merged 2 commits intopython-control:mainfrommurrayrm:fix_isstatic-12Nov2022

Nov 16, 2022

Merged

fix _isstatic() to use nstates==0#790

sawyerbfuller merged 2 commits intopython-control:mainfrommurrayrm:fix_isstatic-12Nov2022

Nov 16, 2022

Conversation

Copy link

Member

murrayrm commentedNov 13, 2022

This PR fixes the issues identified in PR#785 regarding the way thatStateSpace._isstatic was defining a static system. New version requiresnstates == 0.

fix _isstatic() to use nstates==0

c425d2c

Copy link

coveralls commentedNov 13, 2022•
edited
Loading

Coverage decreased (-0.002%) to 94.799% when pullingc82605b on murrayrm:fix_isstatic-12Nov2022 intob32e355 on python-control:main.

roryyorke reviewed

Nov 13, 2022

View reviewed changes

Copy link

Contributor

roryyorke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

control/tests/iosys_test.py

		@@ -51,7 +54,7 @@ class TSys:
		def test_linear_iosys(self, tsys):
		# Create an input/output system from the linear system
		linsys = tsys.siso_linsys
		iosys = ios.LinearIOSystem(linsys)
		iosys = ios.LinearIOSystem(linsys).copy()

Copy link

Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

is it obvious why this.copy is necessary?

Copy link

MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Definitely not obvious, but this gets rid of a warning later on since theinterconnect function generates a warning if a system appears more than once in an interconnected system, since then the name of system is not unique. (It's also possible to turn the warning off withwarn_dupicate=False).