- Notifications
You must be signed in to change notification settings - Fork441
Fix timebase bug in InterconnectedSystem (issue #754)#755
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Conda-based builds are failing. I checked and this is also happening on the current main branch. This may be something associated with Slycot 0.5.0?? |
| (None, 0.1, 0.1), | ||
| (None, None, None), | ||
| (0.2, None, 0.2), | ||
| (0.2, 0.1, ValueError), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Great PR. Would be good to add tests fordt=True, which are compatible with all other discrete-time timebases.https://python-control.readthedocs.io/en/0.9.2/conventions.html
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Great suggestion. Done.
229bfe6 tocf30479Compare
This PR fixes the timebase bug identified in issue#754. The fix was to modify the processing of the timebase in
InterconnectedSystemso that it looks at the systems for the default timebase.