- Notifications
You must be signed in to change notification settings - Fork441
Slycot source uses setuptools_scm now#751
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
coveralls commentedJul 18, 2022 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
@bnavigator This PR looks fine, but I note that it now builds against that latest Slycot in available via pip, versus the previous behavior which checked against the latest version on github. |
Are you sure? This is the latest version on github. |
Ah, I see now. I was confused about how the repository was being check out. I agree the behavior is unchanged. |
python-control/Slycot#180 broke the CI setup for the tests with a Slycot from latest sources (0.5.1.dev6 at the moment).
Given that the change blocks proper CI runs in PRs like#750, I intend to merge this as soon as the CI passes.