Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Passivity indices and support for discrete time systems.#750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
bnavigator merged 40 commits intopython-control:mainfromMark-Yeatman:passivity-tools
Jul 30, 2022

Conversation

Mark-Yeatman
Copy link
Contributor

@Mark-YeatmanMark-Yeatman commentedJul 18, 2022
edited
Loading

This adds support for input and output passivity indices and "is passive or not" for discrete time systems.

@Mark-Yeatman

This comment was marked as resolved.

@bnavigator

This comment was marked as resolved.

@bnavigator

This comment was marked as resolved.

@Mark-Yeatman
Copy link
ContributorAuthor

@bnavigator I've split get_passivity_index() into get_output_fb_index() and get_input_ff_index(). I've also removed all the weird conditionals in ispassive(), it just has one code path now. I kept all the nu's and rho's in _solve_passivity_LMI() because it's easier to match the syntax from the source paper that way IMO.

bnavigator reacted with thumbs up emoji

@murrayrm
Copy link
Member

murrayrm commentedJul 26, 2022
edited by bnavigator
Loading

It looks like the passivity module is not (yet) loaded in__init__.py. You should probably do that, so people don't have to import that passivity module explicitly (which allowsct.ispassive(sys)). Also, we should update the Sphinx documentation to includeispassive in the list of functions that are implemented (indoc/control.rst).

Other than that, looks ready to go?

Mark-Yeatman reacted with thumbs up emoji

Copy link
Member

@murrayrmmurrayrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

More small things to fix (sorry I didn't notice these on my previous pass..).

Add more detailed and clear comments and doc strings.Fix correctness of _solve_passivity_LMI for inputing values for bothinput and output passivity indices. Allow checking of passivity using ispassive givenvalues for input and ouput passivity indices.
… instead of -inf when infeasible.(I'm not sure how to trigger this code for unit testing, mostly a just-in-case.
@Mark-Yeatman
Copy link
ContributorAuthor

You actually need ther""" here or have to use double backslashes below.

Is there a name for what this is?

@bnavigator
Copy link
Contributor

bnavigator commentedJul 30, 2022
edited
Loading

Is there a name for what this is?

"longstring stringliteral with raw stringprefix" or "raw triple-quoted strings"

PEP 257:

For consistency, always use"""triple double quotes""" around docstrings. User"""raw triple double quotes""" if you use any backslashes in your docstrings. For Unicode docstrings, useu"""Unicode triple-quoted strings""".

@Mark-Yeatman
Copy link
ContributorAuthor

Is there a name for what this is?

"longstring stringliteral with raw stringprefix" or "raw triple-quoted strings"

PEP 257:

For consistency, always use"""triple double quotes""" around docstrings. User"""raw triple double quotes""" if you use any backslashes in your docstrings. For Unicode docstrings, useu"""Unicode triple-quoted strings""".

Noice

@murrayrm
Copy link
Member

@Mark-Yeatman@bnavigator This looks like it is ready to merge? Anything else planned?

Mark-Yeatman reacted with thumbs up emoji

@bnavigator
Copy link
Contributor

Thanks@Mark-Yeatman! Looking forward to future pull request with further enhancements of this module.

Mark-Yeatman reacted with rocket emoji

@bnavigatorbnavigator merged commita19c501 intopython-control:mainJul 30, 2022
@murrayrmmurrayrm added this to the0.9.3 milestoneDec 24, 2022
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@murrayrmmurrayrmmurrayrm left review comments

@bnavigatorbnavigatorbnavigator left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.9.3
Development

Successfully merging this pull request may close these issues.

4 participants
@Mark-Yeatman@bnavigator@coveralls@murrayrm

[8]ページ先頭

©2009-2025 Movatter.jp