Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Keyword argument checking#713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
bnavigator merged 8 commits intopython-control:masterfrommurrayrm:kwargs_20Mar2022
Mar 30, 2022

Conversation

@murrayrm
Copy link
Member

@murrayrmmurrayrm commentedMar 23, 2022
edited
Loading

This PR implements checks for unrecognized keywords in all functions that accept variable keywords (addressing#528). This is accomplished using a thekwargs_test unit test, which inspects the module, finds all functions with variable keyword arguments, and then makes sure there is a unit test that confirms that sending an unknown keyword generates an error.

@murrayrmmurrayrm marked this pull request as draftMarch 23, 2022 05:49
@coveralls
Copy link

coveralls commentedMar 23, 2022
edited
Loading

Coverage Status

Coverage increased (+0.8%) to 94.34% when pulling87cb31a on murrayrm:kwargs_20Mar2022 intocfe21de on python-control:master.

@murrayrmmurrayrm marked this pull request as ready for reviewMarch 30, 2022 05:36
@murrayrm
Copy link
MemberAuthor

Rebased and changed from draft to ready to merge. While improvements are possible, this has already caught several bugs (eg, commit3656968, issue#702) and so I think it is OK to merge in.

@bnavigatorbnavigator merged commitcb6d9d7 intopython-control:masterMar 30, 2022
@murrayrmmurrayrm deleted the kwargs_20Mar2022 branchApril 16, 2022 01:03
@murrayrmmurrayrm added this to the0.9.2 milestoneApr 17, 2022
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.9.2

Development

Successfully merging this pull request may close these issues.

Add code to check for unrecognized keywords associated with default settings

3 participants

@murrayrm@coveralls@bnavigator

[8]ページ先頭

©2009-2025 Movatter.jp