- Notifications
You must be signed in to change notification settings - Fork441
Round to nearest integer decade for default omega vector#688
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
coveralls commentedJan 4, 2022 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
@bnavigator In thinking through this overnight, I wonder if we might want to revert to the old behavior (floor, ceil) and update the documentation to match (+ update the unit tests to avoid the corner case). I'm worried that only going out a half decade might now show the asymptotic frequency response. I'll work up a couple of examples and post an issue so that we can discuss. |
Hmm, okay. We need to find another way to make |
Fixes#687.
The docstring for the
_default_frequency_range()
function saysThe old code rounded to the floor and ceiling of the range, which occasionally adds another decade to one or the other end of the frequency range if the feature fallsjust inside of the outermost decade.
The new code rounds to the nearest integer, so it only adds half a decade at minimum.