- Notifications
You must be signed in to change notification settings - Fork441
Fix warning messages in rootlocus_pid_designer unit tests#684
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
murrayrm merged 2 commits intopython-control:masterfrommurrayrm:fix_pid_designer_warningsDec 31, 2021
Merged
Fix warning messages in rootlocus_pid_designer unit tests#684
murrayrm merged 2 commits intopython-control:masterfrommurrayrm:fix_pid_designer_warningsDec 31, 2021
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
coveralls commentedDec 27, 2021
Merging this for 0.9.1, but will create an issue to track the possible bug above. |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR gets rid of warning messages introduced in PR#662:
rootlocus_pid_designer
leaves eitherr
ord
disconnected, theinterconnect
function was generating warnings (76 of them...). This was fixed by usingcheck_unused=False
.rootlocus_pid_designer
withplot=True
seems to generate a Bode plot that is -1 and this creates a warning:For now this latter problem is fixed by skipping this test.
@sawyerbfuller I'm not quite sure how to fix this error. If I try running the test by hand using
then I get the following plot: