Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Fix warning messages in rootlocus_pid_designer unit tests#684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

murrayrm
Copy link
Member

This PR gets rid of warning messages introduced in PR#662:

  • Sincerootlocus_pid_designer leaves eitherr ord disconnected, theinterconnect function was generating warnings (76 of them...). This was fixed by usingcheck_unused=False.
  • Callingrootlocus_pid_designer withplot=True seems to generate a Bode plot that is -1 and this creates a warning:
control/ctrlutil.py:75: RuntimeWarning: invalid value encountered in remainder  dangle_desired = (dangle + period/2.) % period - period/2.

For now this latter problem is fixed by skipping this test.

@sawyerbfuller I'm not quite sure how to fix this error. If I try running the test by hand using

ct.rootlocus_pid_designer(syscont, input_signal='r', Kp0=0.01,    derivative_in_feedback_path=True, gain='P')

then I get the following plot:

Sisotool_pid_designer_bug

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 93.383% when pulling7cfa42a on murrayrm:fix_pid_designer_warnings into8356044 on python-control:master.

@murrayrm
Copy link
MemberAuthor

Merging this for 0.9.1, but will create an issue to track the possible bug above.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@murrayrm@coveralls

[8]ページ先頭

©2009-2025 Movatter.jp