- Notifications
You must be signed in to change notification settings - Fork441
extrapolation in ufun throwed errors#682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
@miroslavfikar It would be great to add a unit test the triggers the error (prior to your fix). |
coveralls commentedDec 12, 2021 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
I updated the fix to use extrapolation, since this is what is supposed to happen. The example now runs without throwing and error. (I couldn't figure out how to create a simple unit test since it seem to depend on the integrator asking to sample outside of the time range.) @miroslavfikar It would be useful if you can confirm that the new version gives a correct result for your example. |
@murrayrm Yes, I confirm, I get the correct results with your commit, thanks. |
I came across situation when interpolation of u in ufun was requested beyond the actual time interval. Attached MWE file throws error, proposed modification resolves the issue. There were two possibilities to resolve the issue: either to take the highest value of time known (interpolation) or to prolonge the last interval to the right (extrapolation). I chose the first one to be consistent with already treated case to the left.
testh2.txt