Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

extrapolation in ufun throwed errors#682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
murrayrm merged 3 commits intopython-control:masterfrommiroslavfikar:mifi_ufun
Dec 26, 2021

Conversation

miroslavfikar
Copy link
Contributor

I came across situation when interpolation of u in ufun was requested beyond the actual time interval. Attached MWE file throws error, proposed modification resolves the issue. There were two possibilities to resolve the issue: either to take the highest value of time known (interpolation) or to prolonge the last interval to the right (extrapolation). I chose the first one to be consistent with already treated case to the left.

testh2.txt

@murrayrm
Copy link
Member

@miroslavfikar It would be great to add a unit test the triggers the error (prior to your fix).

@coveralls
Copy link

coveralls commentedDec 12, 2021
edited
Loading

Coverage Status

Coverage decreased (-0.002%) to 92.721% when pulling9bd61b0 on miroslavfikar:mifi_ufun into2ce4bbd on python-control:master.

@murrayrm
Copy link
Member

I updated the fix to use extrapolation, since this is what is supposed to happen. The example now runs without throwing and error. (I couldn't figure out how to create a simple unit test since it seem to depend on the integrator asking to sample outside of the time range.)

@miroslavfikar It would be useful if you can confirm that the new version gives a correct result for your example.

@miroslavfikar
Copy link
ContributorAuthor

@murrayrm Yes, I confirm, I get the correct results with your commit, thanks.

@murrayrmmurrayrm merged commit8356044 intopython-control:masterDec 26, 2021
@miroslavfikarmiroslavfikar deleted the mifi_ufun branchDecember 26, 2021 18:39
@murrayrmmurrayrm added this to the0.9.1 milestoneDec 30, 2021
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.9.1
Development

Successfully merging this pull request may close these issues.

3 participants
@miroslavfikar@murrayrm@coveralls

[8]ページ先頭

©2009-2025 Movatter.jp