Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

vectorize FRD feedback function#680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

bnavigator
Copy link
Contributor

This is a TODO from#314. It overlaps with#679 and one or the other needs a rebase after merge.

# frd_bench.pyfromcontrolimportFrequencyResponseData,rssimportnumpyasnpomega=np.logspace(-1,4,40000)rss1=rss(6,10,20,True)rss2=rss(6,20,10,True)F1=rss1(omega)F2=rss2(omega)frd1=FrequencyResponseData(F1,omega)frd2=FrequencyResponseData(F2,omega)FB=frd1.feedback(frd2)

current master:

In [1]:fromfrd_benchimportfrd1,frd2In [2]:%timeit-n10-r3frd1.feedback(frd2)1.96s ±10.8msperloop (mean ±std.dev.of3runs,10loopseach)

vectorized:

In [1]:fromfrd_benchimportfrd1,frd2In [2]:%timeit-n10-r3frd1.feedback(frd2)1.29s ±4.48msperloop (mean ±std.dev.of3runs,10loopseach)

@coveralls
Copy link

coveralls commentedDec 2, 2021•
edited
Loading

Coverage Status

Coverage increased (+0.002%) to 92.723% when pulling37c95b6 on bnavigator:vector-frd-feedback into4f681ab on python-control:master.

@bnavigator
Copy link
ContributorAuthor

It overlaps with#679 and one or the other needs a rebase after merge.

Done.

@murrayrmmurrayrm merged commit2ce4bbd intopython-control:masterDec 26, 2021
@murrayrmmurrayrm added this to the0.9.1 milestoneDec 30, 2021
@bnavigatorbnavigator deleted the vector-frd-feedback branchFebruary 18, 2024 20:30
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@murrayrmmurrayrmmurrayrm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.9.1
Development

Successfully merging this pull request may close these issues.

3 participants
@bnavigator@coveralls@murrayrm
[8]ページ先頭
©2009-2025 Movatter.jp