NotificationsYou must be signed in to change notification settings
Fork441
Star1.8k

Remove old pythons and leverage @ operator#679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

murrayrm merged 9 commits intopython-control:masterfrombnavigator:remove-old-python

Dec 26, 2021

Merged

Remove old pythons and leverage @ operator#679

murrayrm merged 9 commits intopython-control:masterfrombnavigator:remove-old-python

Dec 26, 2021

Conversation

Copy link

Contributor

bnavigator commentedDec 2, 2021

We should finally let go of Python 2. It will allow us to use the matmul operator@ and make code more readable.

As NumPy has deprecated Python 3.6 support a while ago (NEP 29), Conda recently dropped it and it will also reach end-of-life in the mainline Python this month, let's also stop testing Python 3.6.

There is an important difference to consider when replacingnp.dot orndarray.dot with@:

Multiplication by scalars is not allowed, use* instead.
Stacks of matrices are broadcast together as if the matrices were elements, respecting the signature(n,k),(k,m)->(n,m):

bnavigator added8 commits

December 2, 2021 13:06

remove support declaration for EOL Python 2 and 3.6

2123d52

remove python2 future imports

7d97ef9

remove travis config

f8534a0

bump minimum python version in GHA conda tests

12f9014

replace np.dot with @ matmul operator where applicable

19cc79a

replace ndarray.dot() with @

6b96c7f

replace np.dot with @ matmul operator where applicable in tests

de85969

replace ndarray.dot in tests

5b28121

bnavigator force-pushed theremove-old-python branch from0a713de to6b96c7fCompare

December 2, 2021 18:08

Copy link

coveralls commentedDec 2, 2021•
edited
Loading

Coverage increased (+0.005%) to 92.721% when pullingde94123 on bnavigator:remove-old-python intoc2f6f8a on python-control:master.

bnavigator mentioned this pull request

Dec 2, 2021

vectorize FRD feedback function#680

Merged

Merge branch 'master' into remove-old-python

de94123

Copy link

Contributor

sawyerbfuller commentedDec 9, 2021

I was really excited when python got the matrix mult operator. really cleans up the code. So it sounds reasonable to me if nobody can give a good reason to keep python 2 around.