Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

return frequency response for 0 and 1-state systems directly#663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
bnavigator merged 2 commits intopython-control:masterfrombnavigator:fast-freqresp
Nov 3, 2021

Conversation

bnavigator
Copy link
Contributor

Inspired by the recent CI failures in the Slycot-less branch of theStateSpace.horner() function. Let's try to minimize this by catching simple systems early.

@bnavigatorbnavigator marked this pull request as ready for reviewNovember 2, 2021 22:32
@bnavigator
Copy link
ContributorAuthor

I tried to debug in the failure of#659, now also occuring in#662, with some debug statements in#660, but could not reliably trigger the miscalculation (compare the GHA jobs here and in the corresponding branch of the forked repo) . I suspect a broken conda environment with Py3.9/Numpy/MKL on GHA.

@bnavigator
Copy link
ContributorAuthor

Ah, not compatible withnp.matrix.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 89.935% when pulling5355b02 on bnavigator:fast-freqresp into5ab0a1c on python-control:master.

@sawyerbfuller
Copy link
Contributor

Are you happy enough to merge this? Then I can check if it fixes the problem in#662

@bnavigatorbnavigator merged commit42cba0c intopython-control:masterNov 3, 2021
@bnavigator
Copy link
ContributorAuthor

Still broken for systems with more states. :(

@murrayrmmurrayrm added this to the0.9.1 milestoneDec 30, 2021
@bnavigatorbnavigator deleted the fast-freqresp branchFebruary 18, 2024 20:30
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.9.1
Development

Successfully merging this pull request may close these issues.

4 participants
@bnavigator@coveralls@sawyerbfuller@murrayrm
[8]ページ先頭
©2009-2025 Movatter.jp