Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Check for unused subsystem signals in InterconnectedSystem#652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@roryyorke
Copy link
Contributor

Add capability to check for unused signals in InterconnectedSystem;
this check is invoked by default byinterconnect.

This would have saved me a few hours when I made three typos in signal names, and I couldn't figure out why my time and frequency responses were all wrong.

Some questions:

  • is check_unused=True a reasonable default? I think it is; it won't take long to scan the unused signals, and, if necessary, add them to theignore_* lists
  • are theignore_* names reasonable? I initially called themdropped_inputs anddropped_outputs, but I decided against that.known_unused_inputs is more explicit, but a bit long.
  • should this be in theInterconnectedSystem constructor, rather than ininterconnect ?

Add capability to check for unused signals in InterconnectedSystem;this check is invoked by default by `interconnect`.
Ignore warnings with match string from conftest.py's `matrixfilter`warning filter.
@coveralls
Copy link

coveralls commentedSep 11, 2021
edited
Loading

Coverage Status

Coverage increased (+0.08%) to 90.006% when pullingfaf3145 on roryyorke:rory/check-interconnect-signals into5ab0a1c on python-control:master.

@murrayrm
Copy link
Member

Quick responses on a few things, based on a quick read:

  • I really like this functionality and completely agree we should include it!

  • I think it would be OK to put this in theinterconnect() function rather than theInterconnectedSystem constructor. The intent ofinterconnect() was to provide some additional processing and a more user-friendly interface.

  • It looks like there are some glitches in the documentation (ignore_inputs appears twice).

@roryyorke
Copy link
ContributorAuthor

Thanks for the feedback. I've fixed the docstring.

think it would be OK to put this in the interconnect()

OK, good. IfInterconnectedSystem is used directly,check_unused_signals is available to be called after mappings have been set up. I also madeunused_signals public, though I don't know what applications it could have.

While writing this, it occurred to me it wouldn't be allthat hard to output aGraphviz dot file, or, possibly, a data structure that could be fed intoNetworkX, to allow respectively visualization and graph-theoretic analysis of the signal flow, but I don't have time for any of that at the moment.

@sawyerbfuller
Copy link
Contributor

Connecting@petercorke into this discussion because he is working on a nice-looking graphical renderer for this kind of interconnection. Not sure it is released yet though.

@petercorke
Copy link

petercorke commentedSep 15, 2021 via email

It’s kind of released, just not publicised at the moment. If you pip install bdsim, then it is available as bdedit.py
On 15 Sep 2021, at 6:10 am, sawyerbfuller ***@***.***> wrote: Connecting@petercorke <https://github.com/petercorke> into this discussion because he is working on a nice-looking graphical renderer for this kind of interconnection. Not sure it is released yet though. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#652 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AC2BIUTJMJFBZIRWI6N7TDDUB6T4FANCNFSM5D22EYMA>.

@sawyerbfullersawyerbfuller merged commitce20b24 intopython-control:masterNov 6, 2021
@roryyorkeroryyorke deleted the rory/check-interconnect-signals branchNovember 8, 2021 18:04
@murrayrmmurrayrm added this to the0.9.1 milestoneDec 30, 2021
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.9.1

Development

Successfully merging this pull request may close these issues.

5 participants

@roryyorke@coveralls@murrayrm@sawyerbfuller@petercorke

[8]ページ先頭

©2009-2025 Movatter.jp