- Notifications
You must be signed in to change notification settings - Fork445
Check for unused subsystem signals in InterconnectedSystem#652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Check for unused subsystem signals in InterconnectedSystem#652
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Add capability to check for unused signals in InterconnectedSystem;this check is invoked by default by `interconnect`.
Ignore warnings with match string from conftest.py's `matrixfilter`warning filter.
coveralls commentedSep 11, 2021 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
murrayrm commentedSep 11, 2021
Quick responses on a few things, based on a quick read:
|
roryyorke commentedSep 12, 2021
Thanks for the feedback. I've fixed the docstring.
OK, good. If While writing this, it occurred to me it wouldn't be allthat hard to output aGraphviz dot file, or, possibly, a data structure that could be fed intoNetworkX, to allow respectively visualization and graph-theoretic analysis of the signal flow, but I don't have time for any of that at the moment. |
sawyerbfuller commentedSep 14, 2021
Connecting@petercorke into this discussion because he is working on a nice-looking graphical renderer for this kind of interconnection. Not sure it is released yet though. |
petercorke commentedSep 15, 2021 via email
It’s kind of released, just not publicised at the moment. If you pip install bdsim, then it is available as bdedit.py … On 15 Sep 2021, at 6:10 am, sawyerbfuller ***@***.***> wrote: Connecting@petercorke <https://github.com/petercorke> into this discussion because he is working on a nice-looking graphical renderer for this kind of interconnection. Not sure it is released yet though. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#652 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AC2BIUTJMJFBZIRWI6N7TDDUB6T4FANCNFSM5D22EYMA>. |
Add capability to check for unused signals in InterconnectedSystem;
this check is invoked by default by
interconnect.This would have saved me a few hours when I made three typos in signal names, and I couldn't figure out why my time and frequency responses were all wrong.
Some questions:
ignore_*listsignore_*names reasonable? I initially called themdropped_inputsanddropped_outputs, but I decided against that.known_unused_inputsis more explicit, but a bit long.InterconnectedSystemconstructor, rather than ininterconnect?