Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix damp method for discrete time systems with a negative real-valued pole#647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

vincentchoqueuse
Copy link
Contributor

(first pull request on GitHub)

When a discrete time system has a real-valued negative pole, the discrete to continuous conversion using the log function returns nan. Then, the damp method is not able to compute the damping and the wn values.

To avoid this problem, the poles must be cast to complex values (https://numpy.org/doc/stable/reference/generated/numpy.log.html)

@coveralls
Copy link

coveralls commentedAug 17, 2021
edited
Loading

Coverage Status

Coverage remained the same at 89.923% when pulling140ca08 on vincentchoqueuse:fix_damp_bug_dlti_system into6b7a9c7 on python-control:master.

Copy link
Contributor

@bnavigatorbnavigator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you! Excellent first PR.

I left some comments, which can be refined before we merge.

@bnavigatorbnavigator linked an issueAug 17, 2021 that may beclosed by this pull request
@bnavigatorbnavigator merged commit18976c1 intopython-control:masterAug 19, 2021
@bnavigator
Copy link
Contributor

Thank you!

@vincentchoqueuse
Copy link
ContributorAuthor

Thank you for your advices@bnavigator !

@murrayrmmurrayrm added this to the0.9.1 milestoneDec 30, 2021
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@bnavigatorbnavigatorbnavigator approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.9.1
Development

Successfully merging this pull request may close these issues.

Result of the damp function for discrete time systems
4 participants
@vincentchoqueuse@coveralls@bnavigator@murrayrm

[8]ページ先頭

©2009-2025 Movatter.jp