- Notifications
You must be signed in to change notification settings - Fork441
Various docstring edits + fixed plot legends on cruise control example#643
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
coveralls commentedJul 31, 2021 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Oh. I just noticed there's ajupyter notebook version of the cruise control example. I'll have to update that too. |
billtubbs commentedAug 1, 2021 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Okay, there's something I don't understand about editing a jupyter notebook. After I make the edits and run the notebook locally, the setup.py test is failing (see test results below):
|
examples/cruise.ipynb Outdated
"language": "python", | ||
"name": "python3" | ||
"name": "conda-env-control-dev-py" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This won't work in the test environment.
The problem with Jupyter notebooks is that they inherit information from your local machine. So the problem is probably something like One fix is to edit the Jupyter notebook directly (in a text editor) and change the code you want to fix. Then commit that change and test it locally, throwing out the new version of the notebook that will be created when you run it (but still making sure it works). Push that up to GitHub and it should be OK. One caveat is that this will leave the notebook with the old figures, which may not be what you want. Alternatively, run the notebook on your local machine and get things working, then go in and manually change the line that said |
No description provided.