Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

add DefaultDict for deprecation handling#619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

bnavigator
Copy link
Contributor

As discussed here:#593 (comment)

@coveralls
Copy link

coveralls commentedApr 29, 2021•
edited
Loading

Coverage Status

Coverage increased (+0.03%) to 89.63% when pullinge0dab93 on bnavigator:defaults-deprecation intodb174b7 on python-control:master.

Copy link
Contributor

@roryyorkeroryyorke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

The idea seems good, see comments on implementation above.

A very brief docstring or comment explaining that DefaultDict is for deprecation might be good.

@roryyorke
Copy link
Contributor

LGTM

@bnavigator
Copy link
ContributorAuthor

Thank you for the review@roryyorke!

@bnavigatorbnavigator merged commit9f27293 intopython-control:masterMay 1, 2021
@murrayrmmurrayrm added this to the0.9.1 milestoneDec 30, 2021
@bnavigatorbnavigator deleted the defaults-deprecation branchFebruary 18, 2024 20:30
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@roryyorkeroryyorkeroryyorke left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.9.1
Development

Successfully merging this pull request may close these issues.

4 participants
@bnavigator@coveralls@roryyorke@murrayrm
[8]ページ先頭
©2009-2025 Movatter.jp