NotificationsYou must be signed in to change notification settings
Fork441
Star1.8k

Fix warnings generated by sisotool#608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

bnavigator merged 1 commit intopython-control:masterfromroryyorke:rory/sisotool-warnings

Apr 11, 2021

Merged

Fix warnings generated by sisotool#608

bnavigator merged 1 commit intopython-control:masterfromroryyorke:rory/sisotool-warnings

Apr 11, 2021

Conversation

Copy link

Contributor

roryyorke commentedApr 11, 2021

Use recommended canvas.manager.{get,set}_window_title instead of
deprecated canvas.{get,set}_window_title.

Remove redundant marker specification in sisotool rlocus plot.canvas.manager.{get,set}_window_title

Fixes these warnings on master (Python 3.9.2, Matplotlib 3.4.1, python-control8299ebb):

ontrol/tests/sisotool_test.py::TestSisotool::test_sisotoolcontrol/tests/sisotool_test.py::TestSisotool::test_sisotool_tvectcontrol/tests/sisotool_test.py::TestSisotool::test_sisotool_tvect_dtcontrol/tests/sisotool_test.py::TestSisotool::test_sisotool_mimo  /home/rory/src/python-control/control/sisotool.py:84: MatplotlibDeprecationWarning:   The get_window_title function was deprecated in Matplotlib 3.4 and will be removed two minor releases later. Use manager.get_window_title or GUI-specific methods instead.    if fig.canvas.get_window_title() != 'Sisotool':control/tests/sisotool_test.py::TestSisotool::test_sisotoolcontrol/tests/sisotool_test.py::TestSisotool::test_sisotool_tvectcontrol/tests/sisotool_test.py::TestSisotool::test_sisotool_tvect_dtcontrol/tests/sisotool_test.py::TestSisotool::test_sisotool_mimo  /home/rory/src/python-control/control/sisotool.py:87: MatplotlibDeprecationWarning:   The set_window_title function was deprecated in Matplotlib 3.4 and will be removed two minor releases later. Use manager.set_window_title or GUI-specific methods instead.    fig.canvas.set_window_title('Sisotool')control/tests/sisotool_test.py::TestSisotool::test_sisotoolcontrol/tests/sisotool_test.py::TestSisotool::test_sisotool_tvectcontrol/tests/sisotool_test.py::TestSisotool::test_sisotool_tvect_dtcontrol/tests/sisotool_test.py::TestSisotool::test_sisotool_mimo  /home/rory/src/python-control/control/rlocus.py:180: UserWarning: marker is redundantly defined by the 'marker' keyword argument and the fmt string "m." (-> marker='.'). The keyword argument will take precedence.    fig.axes[1].plot(control/tests/sisotool_test.py::TestSisotool::test_sisotoolcontrol/tests/sisotool_test.py::TestSisotool::test_sisotool_tvectcontrol/tests/sisotool_test.py::TestSisotool::test_sisotool_tvect_dt  /home/rory/src/python-control/control/rlocus.py:628: UserWarning: marker is redundantly defined by the 'marker' keyword argument and the fmt string "m." (-> marker='.'). The keyword argument will take precedence.    ax_rlocus.plot(

Fix warnings generated by sisotool

7ae6d0a

Use recommended canvas.manager.{get,set}_window_title instead ofdeprecated canvas.{get,set}_window_title.Remove redundant marker specification in sisotool rlocus plot.