Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Change step_info undershoot percentage calculation#590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
Show file tree
Hide file tree
Changes fromall commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletionscontrol/tests/timeresp_test.py
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -301,17 +301,17 @@ def mimo_ss_step_matlab(self):
'SteadyStateValue': -0.5394},
{'RiseTime': 0.0000, # (*)
'SettlingTime': 3.4000,
'SettlingMin': -0.1034,
'SettlingMin': -0.4350, # (*)
'SettlingMax': -0.1485,
'Overshoot': 132.0170,
'Undershoot':79.222, # 0. in MATLAB
'Undershoot':0.,
'Peak': 0.4350,
'PeakTime': .2,
'SteadyStateValue': -0.1875}]]
# (*): MATLAB gives 0.4here, but it is unclear what
#10% and 90% of the steady state response mean, when
# thestep for this channel does not start a 0 for
#0 initial conditions
# (*): MATLAB gives 0.4for RiseTime and -0.1034 for
#SettlingMin, but it is unclear what 10% and 90% of
# thesteady state response mean, when the step for
#this channel does not start a 0.
return T

@pytest.fixture
Expand Down
10 changes: 5 additions & 5 deletionscontrol/timeresp.py
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -923,11 +923,11 @@ def step_info(sysdata, T=None, T_num=None, yfinal=None,
else:
overshoot = 0

# Undershoot
y_us = (sgnInf * yout).min()
dy_us =np.abs(y_us)
ifdy_us > 0:
undershoot =np.abs(100. *dy_us / InfValue)
# Undershoot : InfValue and undershoot must have opposite sign
y_us_index = (sgnInf * yout).argmin()
y_us =yout[y_us_index]
if(sgnInf * y_us) < 0:
undershoot =(-100. *y_us / InfValue)
else:
undershoot = 0

Expand Down

[8]ページ先頭

©2009-2025 Movatter.jp