Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Change step_info undershoot percentage calculation#590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

juanodecc
Copy link
Contributor

Improper systems with negative respose, if do not have inverse
respons, the undershoot must be 0.
This ocurr in the MIMO system used in the step_info test.
I think, the rise time and setting minimun and maximun computed
by this funtion are right in.

Improper systems with negative respose, if do not have inverserespons, the undershoot must be 0.This ocurr in the MIMO system used in the step_info test.I think, the rise time and setting minimun and maximun computedby this funtion are right in.
@coveralls
Copy link

coveralls commentedMar 24, 2021•
edited
Loading

Coverage Status

Coverage remained the same at 89.221% when pulling14a92fe on juanodecc:step_info_improve_undershoot into203cae8 on python-control:master.

Copy link
ContributorAuthor

@juanodeccjuanodecc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

ok... now I see

@juanodecc
Copy link
ContributorAuthor

@bnavigator can you check it. Tank

@bnavigatorbnavigator changed the titleUndershoot value calculus problem. SolvedChange step_info undershoot percentage calculationMar 25, 2021
@bnavigatorbnavigatorforce-pushed thestep_info_improve_undershoot branch fromb957dee to14a92feCompareMarch 25, 2021 00:27
@bnavigator
Copy link
Contributor

I pushed some style cleanups and a I think I have a cleaner formula for the undershoot. Please check.

juanodecc reacted with thumbs up emoji

Copy link
Contributor

@sawyerbfullersawyerbfuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

looks good. removed one array search - > faster - > good

@bnavigatorbnavigator merged commitce4c2b6 intopython-control:masterMar 25, 2021
@bnavigator
Copy link
Contributor

Thanks@juanodecc

juanodecc reacted with thumbs up emoji

@murrayrmmurrayrm added this to the0.9.1 milestoneDec 30, 2021
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@bnavigatorbnavigatorbnavigator left review comments

@sawyerbfullersawyerbfullersawyerbfuller approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.9.1
Development

Successfully merging this pull request may close these issues.

5 participants
@juanodecc@coveralls@bnavigator@sawyerbfuller@murrayrm
[8]ページ先頭
©2009-2025 Movatter.jp