Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

improve forced_response and its documentation#588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
bnavigator merged 12 commits intopython-control:masterfrombnavigator:timeresp-doc
Apr 2, 2021

Conversation

bnavigator
Copy link
Contributor

@bnavigatorbnavigator commentedMar 24, 2021•
edited
Loading

  • Fix doc error forreturn_x as revealed bycontrol.forced_response argument T #586.
  • Remove redundant kwarg defaults. They are in the call signuature. Numpydoc compliant default indication
  • Enhance error message if ctime system without timevector is provided
  • Make sure the returned time vector keeps it's length

@bnavigator
Copy link
ContributorAuthor

bnavigator commentedMar 24, 2021•
edited
Loading

Strange that the markov test fails here too.

https://github.com/python-control/python-control/pull/588/checks?check_run_id=2188093854#step:5:212

A rerun succeeded. Wonder what triggered the length mismatch of Y and U.

@coveralls
Copy link

coveralls commentedMar 24, 2021•
edited
Loading

Coverage Status

Coverage increased (+0.2%) to 89.448% when pullinga8b72f5 on bnavigator:timeresp-doc intof1a9860 on python-control:master.

@bnavigatorbnavigator changed the titleupdate parameter doc and error message for forced_responseimprove forced_response and its documentationMar 26, 2021
@bnavigator
Copy link
ContributorAuthor

bnavigator commentedMar 26, 2021•
edited
Loading

Even without the modifications of this PR,testMarkovResults started to fail sporadically (#588 (comment)), becausescipy.signal.dlsim returns not enough samples when the last element of the time series is just below a multiple ofsys_dt

Fixed witha6ea296

TODO: cover the new lines. They were only triggered by the testMarkovResults test depending on the random seed.

@bnavigatorbnavigator linked an issueMar 30, 2021 that may beclosed by this pull request
bnavigator added a commit to bnavigator/python-control that referenced this pull requestMar 31, 2021
bnavigator added a commit that referenced this pull requestMar 31, 2021
xfail testmarkovResults until#588 is merged
Copy link
Contributor

@sawyerbfullersawyerbfuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks good. Seems reasonable to allow a nonzero start time!

@bnavigatorbnavigator merged commit5434318 intopython-control:masterApr 2, 2021
@murrayrmmurrayrm added this to the0.9.1 milestoneDec 30, 2021
@bnavigatorbnavigator deleted the timeresp-doc branchFebruary 18, 2024 20:30
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@sawyerbfullersawyerbfullersawyerbfuller approved these changes

@murrayrmmurrayrmAwaiting requested review from murrayrm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.9.1
Development

Successfully merging this pull request may close these issues.

control.forced_response argument T
4 participants
@bnavigator@coveralls@murrayrm@sawyerbfuller
[8]ページ先頭
©2009-2025 Movatter.jp