NotificationsYou must be signed in to change notification settings
Fork441
Star1.8k

Step info improve jpp#583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

juanodecc wants to merge2 commits intopython-control:masterfromjuanodecc:step_info_improve_jpp

Closed

Step info improve jpp#583

juanodecc wants to merge2 commits intopython-control:masterfromjuanodecc:step_info_improve_jpp

Conversation

Copy link

Contributor

juanodecc commentedMar 20, 2021

WIP:@bnavigator check this new feature... I tested it with a mimo system from matlab help online. This new version improve the undershoot calculus. The undershoot ocurr when the value have diferent sign respect the y_final... the system must have inverse response

For discusions:

In the test for MIMO systems, I had to modifie the result of SettlingTimeMin for pass the test, because I think Matlab result is wrong. (the script take max and min after rise time, and this orcurr at Tr = 0)
The Tr calculs have an error of one DT when compute the Tr for digital systems (like mimo system used for testing) because the script compute the Tr with the two points far. (this is easy to implement)

TODO (WIP): make a new function to compute step_info for data from external simulations or stimulations: step_info_data(t,y,y_final)

juanodecc added2 commits

March 18, 2021 16:25

new feature and bug fixes:

f7d3db5

Now can compute the step response characteristics for MIMO systems.Fix undershoot caculus for sistems with negative response.

modify the help according to the new characteristics

8d5810f

and add a working example too, finaly I corrected the see also to referring to functions of this library

Copy link

Contributor

bnavigator commentedMar 20, 2021

Your commits have a date from 2 days ago and they are based on an older commit. Please check#577, which is already merged. We essentially did very similar changes. Could you have a look and make further improvements such as the undershoot calculation based on current master please?

You can discard your unit tests and just change the existing references for the undershoot value, if necessary.