Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

enhance step_info to MIMO and time series of response data#577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
murrayrm merged 13 commits intopython-control:masterfrombnavigator:mimo-step-info
Mar 20, 2021

Conversation

bnavigator
Copy link
Contributor

Enhance thestep_info() function to return a 2D list of info dicts for MIMO systems.

Cleaned up the code a little.

Fixes#574

WIP: needs unit tests for MIMO

@bnavigator
Copy link
ContributorAuthor

Ping@juanodecc

@coveralls
Copy link

coveralls commentedMar 17, 2021•
edited
Loading

Coverage Status

Coverage increased (+0.08%) to 89.028% when pullinga878846 on bnavigator:mimo-step-info into22b9953 on python-control:master.

@bnavigatorbnavigator marked this pull request as ready for reviewMarch 17, 2021 21:56
@juanodecc
Copy link
Contributor

sorry i dont understand ... i has make a new version of step_info which supports MIMO systems on my branch, but now i dont know what i should do. Git is so complicated for my

@bnavigator
Copy link
ContributorAuthor

Please just wait. I am working on this PR right now. Also, note that I am dumb. The current version of this PR does not do really do MIMO. I should know better.

@bnavigator
Copy link
ContributorAuthor

Had to make some adjustments to the automatic calculation of timevectors. Surely one wants to havetfinal included into the generated timevector.

sawyerbfuller reacted with thumbs up emoji

@bnavigatorbnavigator changed the titleenhance step_info to MIMOenhance step_info to MIMO and time series of response dataMar 19, 2021
@bnavigator
Copy link
ContributorAuthor

Now also supports a time series of reponse data as parameter, which could come from measurements or another simulation.

@bnavigatorbnavigatorforce-pushed themimo-step-info branch 4 times, most recently from3660e15 toab555ddCompareMarch 19, 2021 15:03
@murrayrm
Copy link
Member

@bnavigator Is this now good to go?

@sawyerbfuller Do you want to have a final look before merge? This will go into 0.9.0.

@bnavigator
Copy link
ContributorAuthor

As far as I am concerned, it is good to go. The time response data part has not been reviewed yet.

After#579 is merged some of the.real treatment fordcgain() and InfValue is obsolete. So, if#579 is going to be merged before, I will have the change to clean this up a little.

@murrayrm
Copy link
Member

I'll merge#579 now and then we can rebase this one (and give@sawyerbfuller a chance to have a look at the time response data part). I can also dig into if he is busy.

@sawyerbfuller
Copy link
Contributor

Looks good to me

@sawyerbfullersawyerbfuller self-requested a reviewMarch 20, 2021 03:03
@murrayrmmurrayrm merged commit76d51ff intopython-control:masterMar 20, 2021
@murrayrmmurrayrm added this to the0.9.0 milestoneMar 20, 2021
@bnavigatorbnavigator deleted the mimo-step-info branchFebruary 18, 2024 20:30
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@murrayrmmurrayrmmurrayrm left review comments

@sawyerbfullersawyerbfullersawyerbfuller approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.9.0
Development

Successfully merging this pull request may close these issues.

step_info error for MIMO system
5 participants
@bnavigator@coveralls@juanodecc@murrayrm@sawyerbfuller
[8]ページ先頭
©2009-2025 Movatter.jp