NotificationsYou must be signed in to change notification settings
Fork441
Star1.8k

support discrete system as input for FRD#568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

sawyerbfuller merged 1 commit intopython-control:masterfrombnavigator:discretesys2frd

Mar 12, 2021

Merged

support discrete system as input for FRD#568

sawyerbfuller merged 1 commit intopython-control:masterfrombnavigator:discretesys2frd

Mar 12, 2021

Conversation

Copy link

Contributor

bnavigator commentedMar 12, 2021

Triggered by#566 and#523, it was revealed that the evaluation of the sys parameter does not take into account discrete time systems.

support discrete system as input for FRD

fd80fc8

bnavigator mentioned this pull request

Mar 12, 2021

new method keyword in stability_margins and auto-fallback back to FRD ..#566

Merged

Copy link

ContributorAuthor

bnavigator commentedMar 12, 2021

... needs unit tests.

Copy link

coveralls commentedMar 12, 2021

Coverage decreased (-0.04%) to 88.821% when pullingfd80fc8 on bnavigator:discretesys2frd into92de12d on python-control:master.

sawyerbfuller approved these changes

Mar 12, 2021

View reviewed changes

Copy link

Contributor

sawyerbfuller left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks good to me! One remark:FRD.__call__ only works with purely imaginary arguments of the formomega*1j, which I think is still what we want, right? The alternative is if an FRD system derived from a discrete time system thatz must be on the unit circle. I think I favor the former but I am not positive that is the "right" way or not.