- Notifications
You must be signed in to change notification settings - Fork441
fix isssues arising in merge of descfcn/iosys changes#540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
sawyerbfuller merged 1 commit intopython-control:masterfrommurrayrm:fix_descfcn_iosys_mergeFeb 11, 2021
Merged
fix isssues arising in merge of descfcn/iosys changes#540
sawyerbfuller merged 1 commit intopython-control:masterfrommurrayrm:fix_descfcn_iosys_mergeFeb 11, 2021
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a problem that popped up when merging changes from PR#536 with PR#521 that showed up as test failures in the master branch, as pointed out by@sawyerbfuller in comments in (merged) PR#536.
The issue had to do with some pre-processing that was being done for
iosys.pybut that left a latent bug that showed up in one of the describing function unit tests (having to do with how theinputparameter is processed). While fixing that, I also found a bug in the way that the describing function code called an output processing function, so fixed that at the same time.We should review and merge this quickly, since the master branch is currently broken.