Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

I/O system updates#536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

murrayrm
Copy link
Member

Addresses issue#530:

  • Automatic summation and splitting for implicit signal connections fixed.
  • Theinplist andoutlist can how be omitted if you are using automatic signal names by usinginputs andoutputs to list signal names that appear in the list of subsystems to be connected.
  • For easier readability,input andoutput can be used in place ofinputs andoutputs.

Combined, these changes allow the following simplified commands for interconnecting systems via signal names:

    P = ct.tf2io(ct.tf(1, [1, 0]), input='u', output='y')    C = ct.tf2io(ct.tf(10, [1, 1]), input='e', output='u')    sumblk = ct.summing_junction(inputs=['r', '-y'], output='e')    T = ct.interconnect((P, C, sumblk), input='r', output='y')

@murrayrmmurrayrm linked an issueFeb 7, 2021 that may beclosed by this pull request
@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 87.743% when pulling2538a06 on murrayrm:iosys_updates intod75c395 on python-control:master.

super(NonlinearIOSystem, self).__init__(
inputs=inputs, outputs=outputs, states=states,
params=params, dt=dt, name=name
)

# Make sure all input arguments got parsed
if kwargs:
raise TypeError("unknown parameters %s" % kwargs)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

🤙

@sawyerbfullersawyerbfuller merged commit2c132c9 intopython-control:masterFeb 9, 2021
@sawyerbfuller
Copy link
Contributor

After merging the master branch is now failing tests - perhaps a conflict with the new describing functions system.

I'm not quite able to tell what is going on. Indescfcn_test.py I tried changing instantiations ofct.NonlinearIOSystem(None, ... , input=1, output=1) and similar, replacinginput withinputs. But when I run pytest locally, another error appears in_process_time_response()@murrayrm any ideas?

@murrayrm
Copy link
MemberAuthor

Looks like something went wrong in the merge. I'll have a look tonight.

@sawyerbfuller
Copy link
Contributor

Just a quick update: I've put the new auto-summing and auto-splitting, and general interconnect features to use. I've used them to make quite complex feedback systems with any topology I want. In particular, I was able to create software in a few tens of lines of codes that allows me to perform a root locus gain selection -- and plot the step response in SISOTOOL -- for all three gains in a PID controller independently. This entailed an interconnection of about ten subsystems.

@murrayrmmurrayrm added this to the0.9.0 milestoneMar 20, 2021
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@sawyerbfullersawyerbfullersawyerbfuller left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.9.0
Development

Successfully merging this pull request may close these issues.

new iosys.interconnect is great, but...
3 participants
@murrayrm@coveralls@sawyerbfuller
[8]ページ先頭
©2009-2025 Movatter.jp