NotificationsYou must be signed in to change notification settings
Fork441
Star1.8k

sisotool small visual cleanup, new feature to show step response of different input-output than loop#531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

bnavigator merged 7 commits intopython-control:masterfromsawyerbfuller:sisotooling

Feb 7, 2021

Merged

sisotool small visual cleanup, new feature to show step response of different input-output than loop#531

bnavigator merged 7 commits intopython-control:masterfromsawyerbfuller:sisotooling

Feb 7, 2021

Conversation

Copy link

Contributor

sawyerbfuller commentedFeb 4, 2021•
edited
Loading

This PR adds a new feature to sisotool that allows it to show the step response of a system that is not the loop transfer function L. Some visual cleanup including reducing oversized axis tick labels.

To see a the step response of a more complicated system that includes a feedforward controller, or any other input-output pair, you can do so by passing sisotool a 2 input, 2-output system. The gain you choose when you click the rlocus plot gets inserted between output[0] and input[0], and then the step response is between input[1] and output[1].
Doubled the click threshold size in rlocus because I had a hard time aiming the mouse well enough to get successful click events.

sawyerbfuller added3 commits

February 4, 2021 12:48

bdalg.connect now works with scalar inputv and outputv

26a595f

sisotool's step response plot can be something other than feedback(K*…

9b10121

…sys) by providing a 2-input, 2-output system; some visual cleanup

relaxed fiddly click size threshold in rlocus

76b0507

Copy link

coveralls commentedFeb 4, 2021•
edited
Loading

Coverage increased (+0.3%) to 87.948% when pullingabca69d on sawyerbfuller:sisotooling into73f65df on python-control:master.

Copy link

Contributor

bnavigator commentedFeb 4, 2021

👍

Pictures please?
Please cover the 2-in, 2-out case and the MIMO Exception with tests:https://coveralls.io/builds/36879506/source?filename=control%2Fsisotool.py#L162

fixed that full 2x2 system wasn't being passed around correctly, givi…

77bc5c5

…ng wrong step response

Copy link

ContributorAuthor

sawyerbfuller commentedFeb 4, 2021

Here's a current screenshot:

added the unit tests, which caught a bug : ) and docstring cleanup

03cdab7

Copy link

Contributor

bnavigator commentedFeb 5, 2021

Nice. Let's go all the way and cover these two lines as well:

https://coveralls.io/builds/36884037/source?filename=control%2Fsisotool.py#L170
https://coveralls.io/builds/36884037/source?filename=control%2Fsisotool.py#L172

improved test coverage, pep8 cleanup, doc clarification, removed comp…

fc8f8d7

…atibility with matplotlib 1 released 10 years ago

bnavigator reviewed

Feb 5, 2021

View reviewed changes

control/tests/sisotool_test.py Outdated

Comment on lines 124 to 137


		# test supply tvect
		sisotool(sys, tvect=np.arange(0, 1, .1))

		# test discrete-time
		sisotool(sysdt, tvect=5)

		# test MIMO compatibility
		# sys must be siso or 2 input, 2 output
		with pytest.raises(ControlMIMONotImplemented):
		sisotool(sys221)
		# does not raise an error:
		sisotool(sys222)