Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Freqplot improvements#522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

sawyerbfuller
Copy link
Contributor

@sawyerbfullersawyerbfuller commentedJan 28, 2021•
edited
Loading

fixes to freqplot.py:

  • empty glyph in margin plot
  • evalfr(sys,s)->sys(s)
  • changed to a reasonable number of frequency points (1000) in bode plots (up from a very coarse 50)
  • unify frequency range specification between bode and nyquist
    edit:
  • mag/phase data in bode plot is now plotted along with vertical nyquist freq line for DT systems so that it is convenient to calllegend(('sys1', 'sys2'))
  • unit tests for frequency ranges

…lt of 50 for logspace; unify frequency range specification for bode and nyquist
…lt of 50 for logspace; unify frequency range specification for bode and nyquist
@coveralls
Copy link

coveralls commentedJan 28, 2021•
edited
Loading

Coverage Status

Coverage decreased (-0.07%) to 87.685% when pulling73ce1a6 on sawyerbfuller:freqplot-improvements into6d51358 on python-control:master.

@sawyerbfuller
Copy link
ContributorAuthor

added a commit because changes were not necessary and to avoid a merge conflict with#521

@@ -78,8 +78,8 @@ def test_sisotool(self, sys):

# Check if the bode_mag line has moved
bode_mag_moved = np.array(
[111.83321224, 92.29238035, 76.02822315, 62.46884113, 51.14108703,
41.6554004, 33.69409534, 27.00237344, 21.38086717, 16.67791585])
[674.0242, 667.8354, 661.7033, 655.6275, 649.6074, 643.6426,
Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Had to Change this because new number of sampling points.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@murrayrmmurrayrmmurrayrm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.9.0
Development

Successfully merging this pull request may close these issues.

3 participants
@sawyerbfuller@coveralls@murrayrm
[8]ページ先頭
©2009-2025 Movatter.jp