Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix rlocus plotting problem in Jupyter notebooks + comments, PEP8#503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

murrayrm
Copy link
Member

@murrayrmmurrayrm commentedJan 9, 2021•
edited
Loading

This PR resolves issue#464. I added some comments to the code along the way as I was trying to sort out what was going wrong. No easy unit tests for this one, I think, since it seems like the issue is restricted to Jupyter notebooks and has to do with the way they generate plots (I guess).

Before (need to zoomway in to see the plot)
jupyter_bug-before

After:
jupyter_bug-after

@murrayrmmurrayrm linked an issueJan 9, 2021 that may beclosed by this pull request
@coveralls
Copy link

coveralls commentedJan 9, 2021•
edited
Loading

Coverage Status

Coverage increased (+11.03%) to 87.675% when pulling4b88452 on murrayrm:fix_rlocus_jupyter intoa82b520 on python-control:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+10.9%) to 87.537% when pulling4b88452 on murrayrm:fix_rlocus_jupyter intoa82b520 on python-control:master.

@bnavigator
Copy link
Contributor

LGTM.

Could you post before-after pictures here?

The coveralls increase by 11% is a lie, because the last Travis run on master failed with server errors.

Uncovered line:https://coveralls.io/builds/36205925/source?filename=control%2Frlocus.py#L247. At least call the plot function with a dtime sys once?

Maybehttps://matplotlib.org/devel/testing.html#writing-an-image-comparison-test is also worth a try.

@murrayrmmurrayrm merged commit8194b1d intopython-control:masterJan 14, 2021
@murrayrmmurrayrm deleted the fix_rlocus_jupyter branchJanuary 14, 2021 07:04
@murrayrmmurrayrm added this to the0.9.0 milestoneMar 20, 2021
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.9.0
Development

Successfully merging this pull request may close these issues.

root_locus() plot figure size issue - ipynotebook
3 participants
@murrayrm@coveralls@bnavigator
[8]ページ先頭
©2009-2025 Movatter.jp