Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

REBASE: use __call__ instead of evalfr in lti system classes#499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed

Conversation

murrayrm
Copy link
Member

This is a rebase of PR#449.

@murrayrm
Copy link
MemberAuthor

Requesting a second look from@bnavigator,@sawyerbfuller just to make sure it all still looks OK. Will merge as soon as they approve.

@bnavigator
Copy link
Contributor

bnavigator commentedJan 6, 2021
edited
Loading

The change for frd_test.py::test_eval() got lost.

Fix in73fc6a6

@bnavigator
Copy link
Contributor

@sawyerbfuller are you okay with this single commit squashing all your contributions? Otherwise you couldmerge (not pick!) the commit into your origin:call-method. (Seesawyerbfuller#1 (comment))

Let's also wait on Travis. The scheduler is particularly slow today.

@coveralls
Copy link

coveralls commentedJan 6, 2021
edited
Loading

Coverage Status

Coverage decreased (-0.2%) to 87.32% when pulling195bec3 on murrayrm:call-method_rebase into4103688 on python-control:master.

@bnavigator
Copy link
Contributor

I pushed your rebase into#449. We can continue discussion in the original PR.

@murrayrm
Copy link
MemberAuthor

Thanks,@bnavigator.

@sawyerbfuller
Copy link
Contributor

@sawyerbfuller are you okay with this single commit squashing all your contributions? Otherwise you couldmerge (not pick!) the commit into your origin:call-method.

is this still relevant now that#449 is now (mostly) rebased?

@bnavigator
Copy link
Contributor

I addressed all my comments and pushed into your branch. Even with your small edit in between. Hooray for git 😀

sawyerbfuller reacted with hooray emoji

@murrayrmmurrayrm deleted the call-method_rebase branchJanuary 14, 2021 07:05
@murrayrmmurrayrm modified the milestone:0.9.0Mar 20, 2021
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@bnavigatorbnavigatorbnavigator left review comments

@sawyerbfullersawyerbfullerAwaiting requested review from sawyerbfuller

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@murrayrm@bnavigator@coveralls@sawyerbfuller

[8]ページ先頭

©2009-2025 Movatter.jp