Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

TransferFunction array priority plus system type conversion checking#498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

murrayrm
Copy link
Member

(This PR builds on#497, which is required for some of the functionality.)

This PR updates the__array_priority__ variable in the TransferFunction class that is used bynumpy, as described in issue#459. With this change, multiplying a transfer function by anndarray object gives a transfer function.

I also created a new unit test (control/tests/type_converstion_test.py) that goes through the matrix of interconnections in#497 and confirms that output type for each operation. In this current PR, no new functionality is included, but I did mark those entries that should (eventually) be updated. Depending on what people think about the PR, we can either leave those for another time or put them into this PR.

@murrayrmmurrayrm changed the titleTransferFunction array priority plus system type conversion checkinTransferFunction array priority plus system type conversion checkingJan 4, 2021
@coveralls
Copy link

coveralls commentedJan 4, 2021
edited
Loading

Coverage Status

Coverage increased (+0.2%) to 87.677% when pullinge910c22 on murrayrm:array_priority+system_composition into0eb4396 on python-control:master.

@bnavigator
Copy link
Contributor

So, wait on#497?

I also created a new unit test (control/tests/type_converstion_test.py)

On first glance, the test file looks good.

@murrayrm
Copy link
MemberAuthor

I'll update#497 tonight and also do one more small change here (putting in the final table of conversations for later use). Once#497 is integrated, I'll make sure this is rebased against that (should be OK, I think, since I started with that as my initial branch) and then we can merge this one as well.

@murrayrmmurrayrmforce-pushed thearray_priority+system_composition branch from356189e to06b7718CompareJanuary 5, 2021 19:09
@murrayrmmurrayrm linked an issueJan 5, 2021 that may beclosed by this pull request
murrayrmand others added11 commitsJanuary 6, 2021 11:39
Co-authored-by: Ben Greiner <code@bnavigator.de>
@murrayrmmurrayrmforce-pushed thearray_priority+system_composition branch from06b7718 toe910c22CompareJanuary 8, 2021 05:57
@murrayrmmurrayrm merged commit2d6c47f intopython-control:masterJan 8, 2021
@murrayrmmurrayrm mentioned this pull requestJan 8, 2021
@murrayrmmurrayrm deleted the array_priority+system_composition branchJanuary 14, 2021 07:04
@murrayrmmurrayrm added this to the0.9.0 milestoneMar 20, 2021
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@bnavigatorbnavigatorbnavigator left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.9.0
Development

Successfully merging this pull request may close these issues.

numpy.ndarray * control.TransferFunction gives array object
4 participants
@murrayrm@coveralls@bnavigator@sawyerbfuller

[8]ページ先頭

©2009-2025 Movatter.jp