- Notifications
You must be signed in to change notification settings - Fork441
TransferFunction array priority plus system type conversion checking#498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
TransferFunction array priority plus system type conversion checking#498
Uh oh!
There was an error while loading.Please reload this page.
Conversation
coveralls commentedJan 4, 2021 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
So, wait on#497?
On first glance, the test file looks good. |
I'll update#497 tonight and also do one more small change here (putting in the final table of conversations for later use). Once#497 is integrated, I'll make sure this is rebased against that (should be OK, I think, since I started with that as my initial branch) and then we can merge this one as well. |
Uh oh!
There was an error while loading.Please reload this page.
356189e
to06b7718
CompareCo-authored-by: Ben Greiner <code@bnavigator.de>
06b7718
toe910c22
Compare
(This PR builds on#497, which is required for some of the functionality.)
This PR updates the
__array_priority__
variable in the TransferFunction class that is used bynumpy
, as described in issue#459. With this change, multiplying a transfer function by anndarray
object gives a transfer function.I also created a new unit test (
control/tests/type_converstion_test.py
) that goes through the matrix of interconnections in#497 and confirms that output type for each operation. In this current PR, no new functionality is included, but I did mark those entries that should (eventually) be updated. Depending on what people think about the PR, we can either leave those for another time or put them into this PR.