Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

ENH: add bdschur, which calls Slycot mb03rd. Change modal_form to us…#495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
murrayrm merged 4 commits intopython-control:masterfromroryyorke:rory/modal-form
Jan 15, 2021

Conversation

roryyorke
Copy link
Contributor

…e bdschur

The bdschur interface is modelled after the Matlab function of the
same name; it can also optionally sort the modal blocks.

Added tests for bdschur, and modified tests for modal_form.

Closes#318

@coveralls
Copy link

coveralls commentedJan 1, 2021•
edited
Loading

Coverage Status

Coverage increased (+0.1%) to 87.648% when pulling8fc3627 on roryyorke:rory/modal-form intofeb9fc9 on python-control:master.

Copy link
Contributor

@bnavigatorbnavigator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Nice! Some comments about the docstrings and test suite. Can't say much about the algorithms themselves.

@roryyorke
Copy link
ContributorAuthor

Thanks@bnavigator ! I've added the@slycotonly decorator, and updated the docs. I did some minor mods to the other docstrings incanonical.py too, and addedbdschur andmodal_form to control.rst.

roryyorkeand others added4 commitsJanuary 14, 2021 21:45
… bdschurThe bdschur interface is modelled after the Matlab function of thesame name; it can also optionally sort the modal blocks.Added tests for bdschur, and modified tests for modal_form.
@murrayrm
Copy link
Member

Rebased and changed_convertToStateSpace to_convert_to_statespace. Will merge as soon as Travis finishes up.

@murrayrmmurrayrm merged commitad0a0eb intopython-control:masterJan 15, 2021
@murrayrmmurrayrm added this to the0.9.0 milestoneMar 20, 2021
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@bnavigatorbnavigatorbnavigator left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.9.0
Development

Successfully merging this pull request may close these issues.

modal canonical form does not work with repeated eigenvalues
4 participants
@roryyorke@coveralls@murrayrm@bnavigator
[8]ページ先頭
©2009-2025 Movatter.jp