- Notifications
You must be signed in to change notification settings - Fork441
implementation of initial_phase, wrap_phase keywords for bode()#494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
bnavigator merged 3 commits intopython-control:masterfrommurrayrm:bode_initial_wrap_phaseJan 2, 2021
Merged
implementation of initial_phase, wrap_phase keywords for bode()#494
bnavigator merged 3 commits intopython-control:masterfrommurrayrm:bode_initial_wrap_phaseJan 2, 2021
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
coveralls commentedDec 31, 2020 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
coveralls commentedDec 31, 2020
bnavigator requested changesJan 1, 2021
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
bnavigator approved these changesJan 2, 2021
murrayrm added a commit to murrayrm/python-control that referenced this pull requestJan 4, 2021
…on-control#494)* implementation of initial_phase, wrap_phase keywords for bode()* add additional documentation on initial_phase if deg=False* clear figure in unit tests to avoid slow plotting problem
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds
initial_phase
andwrap_phase
keywords tobode
, which allow you to tune the behavior of the phase portion of a Bode plot. The default behavior should more or less match previous behavior, except that the default initial phase will be between 0 and -360 degrees (so 1/s^3 will start with phase -270).Resolves issue#467.