NotificationsYou must be signed in to change notification settings
Fork441
Star1.8k

generate error for tf2ss of non-proper transfer function#492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

bnavigator merged 2 commits intopython-control:masterfrommurrayrm:iosys-nonproper-tf

Dec 31, 2020

Merged

generate error for tf2ss of non-proper transfer function#492

bnavigator merged 2 commits intopython-control:masterfrommurrayrm:iosys-nonproper-tf

Dec 31, 2020

Conversation

Copy link

Member

murrayrm commentedDec 31, 2020•
edited
Loading

This PR resolves issue#399 whentf2io is called with a non-proper transfer function (which cannot be represented as a state space system). The underlying issue turned out to be intf2ss, which had the same bug and was probably introduced in PR#370 when we started allowing non-proper transfer functions.

Added unit tests to catch the case and then fixed them by generating aValueError when you try to convert a non-proper transfer function into aStateSpace object.

Also did some PEP8 cleanup onstatesp.py.