NotificationsYou must be signed in to change notification settings
Fork441
Star1.8k

Fix loading of defaults during pytest fixture setup#489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

bnavigator merged 1 commit intopython-control:masterfrombnavigator:fix-defaults

Dec 31, 2020

Merged

Fix loading of defaults during pytest fixture setup#489

bnavigator merged 1 commit intopython-control:masterfrombnavigator:fix-defaults

Dec 31, 2020

+34 −5

Conversation

Copy link

Contributor

bnavigator commentedDec 30, 2020

Also make matarrayout and matarrayin function scoped fixtures so
that they can set the warnings filters individually as needed for
each test.

Fixes#488

Fix loading of defaults during pytest fixture setup

abf1565

Also make matarrayout and matarrayin function scoped fixtures sothat they can set the warnings filters individually as needed foreach test.

Copy link

coveralls commentedDec 30, 2020

Coverage decreased (-0.2%) to 86.839% when pullingabf1565 on bnavigator:fix-defaults intod66f4e4 on python-control:master.

Copy link

coveralls commentedDec 30, 2020•
edited
Loading

Coverage decreased (-0.06%) to 86.98% when pullingabf1565 on bnavigator:fix-defaults intod66f4e4 on python-control:master.

Copy link

Member

murrayrm commentedDec 31, 2020

I'm not enough of a pytest guru (yet -:) to understand this in detail. OK by me to merge unless you feel that someone else should have a closer look first.

Copy link

ContributorAuthor

bnavigator commentedDec 31, 2020

I think I tested it thoroughly on my local machine. Given that it affects only the test suite and not the end user I feel confident enough to merge it with "just" your OK.