Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

deprecate np.matrix usage#486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
murrayrm merged 2 commits intopython-control:masterfrombnavigator:deprecate-matrix
Dec 30, 2020

Conversation

bnavigator
Copy link
Contributor

As previously discussed and announced: 0.9 deprecates np.matrix usage

@coveralls
Copy link

Coverage Status

Coverage decreased (-10.01%) to 76.606% when pullingf9d4a9c on bnavigator:deprecate-matrix into51c797e on python-control:master.

@coveralls
Copy link

coveralls commentedDec 30, 2020•
edited
Loading

Coverage Status

Coverage remained the same at 87.04% when pulling1565097 on bnavigator:deprecate-matrix intoc432fd5 on python-control:master.

@bnavigator
Copy link
ContributorAuthor

#438 will handle the CI fail: The warning category changed.

@roryyorke
Copy link
Contributor

Assume it's OK to change tests to usenp.array instead ofnp.matrix then? This caught me out while debugging a test failure incanonical_test.py today.

@murrayrm
Copy link
Member

You might want to have a look at#438 and wait until that is merged before making changes to tests (they are undergoing significant refactoring).

We are waiting on CI tests to run, but merges should happen today.

@murrayrmmurrayrm merged commitec42737 intopython-control:masterDec 30, 2020
@bnavigator
Copy link
ContributorAuthor

Now that#438 is merged, this passes. But with removing the filter as discussed#438 (comment) it seems that the actual new default is not set properly during the test suite run.

@bnavigatorbnavigator deleted the deprecate-matrix branchJanuary 5, 2021 20:18
@murrayrmmurrayrm added this to the0.9.0 milestoneMar 20, 2021
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@murrayrmmurrayrmmurrayrm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.9.0
Development

Successfully merging this pull request may close these issues.

4 participants
@bnavigator@coveralls@roryyorke@murrayrm
[8]ページ先頭
©2009-2025 Movatter.jp