NotificationsYou must be signed in to change notification settings
Fork441
Star1.8k

handle empty pole vector for timevector calculation#485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

murrayrm merged 1 commit intopython-control:masterfrombnavigator:timevector-fix

Dec 30, 2020

Merged

handle empty pole vector for timevector calculation#485

murrayrm merged 1 commit intopython-control:masterfrombnavigator:timevector-fix

Dec 30, 2020

Conversation

Copy link

Contributor

bnavigator commentedDec 29, 2020

The automatic timevector calculation sometimes encounters empty vectors. The small random systems used in the test suite sometimes fail (Refactor the test suite using pytest for array and matrix types #438).
Escape the LaTeX formula in the docstring to avoid warning messages. Sphinx can still handle it.

handle empty pole vector for timevector calculation

1603e85

bnavigator mentioned this pull request

Dec 30, 2020

Refactor the test suite using pytest for array and matrix types#438

Merged

Copy link

coveralls commentedDec 30, 2020•
edited
Loading

Coverage increased (+0.003%) to 86.621% when pulling1603e85 on bnavigator:timevector-fix into51c797e on python-control:master.

bnavigator requested a review fromsawyerbfuller

December 30, 2020 16:11

bnavigator mentioned this pull request

Dec 30, 2020

Release 0.8.4 and 0.9.0 sequencing#451

Closed

murrayrm approved these changes

Dec 30, 2020

View reviewed changes

Copy link

Member

murrayrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This PR looks fine. The code itself could use some documentation and the reuse of m_u as a subset of p_u is confusing, but not something that needs to be fixed here.