- Notifications
You must be signed in to change notification settings - Fork441
Stability margins for discrete time systems#469
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Very nice, Looks good to me. Not sure why the previous author used an arcane incantation rather than just numpy.polyval in _poly_iw(), but maybe there is a numeric justification when working with imaginary arguments that I don’t know about.
I don’t have any good ideas for an analytic solution to the optimization problem.
Uh oh!
There was an error while loading.Please reload this page.
Both yours /@repagh's and@swaldherr's (is there a more current GitHub handle?) implementations are very similar. They split the polynomials up into real and imaginary parts after applying |
coveralls commentedNov 17, 2020 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
c05e179
toad0a225
CompareI think this should go into 0.8.4. It enhances functionality, but does not change the API and it fixes the bug that it returns wrong results with discrete input. |
My attempt tofix#465
If someone has an idea how to solve
min |1 + num(z) / den(z) |
withz=exp(i w dt)
analytically, that would be great. I opted for a numerical optimization instead.