Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Stability margins for discrete time systems#469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

bnavigator
Copy link
Contributor

My attempt tofix#465

If someone has an idea how to solvemin |1 + num(z) / den(z) | withz=exp(i w dt) analytically, that would be great. I opted for a numerical optimization instead.

Copy link
Contributor

@sawyerbfullersawyerbfuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Very nice, Looks good to me. Not sure why the previous author used an arcane incantation rather than just numpy.polyval in _poly_iw(), but maybe there is a numeric justification when working with imaginary arguments that I don’t know about.

I don’t have any good ideas for an analytic solution to the optimization problem.

@bnavigator
Copy link
ContributorAuthor

Not sure why the previous author used an arcane incantation rather than just numpy.polyval in _poly_iw(),

Both yours /@repagh's and@swaldherr's (is there a more current GitHub handle?) implementations are very similar. They split the polynomials up into real and imaginary parts after applying, and just store the result in a different variable structure. I just refactored to remove the "duplicate" code.

@coveralls
Copy link

coveralls commentedNov 17, 2020
edited
Loading

Coverage Status

Coverage increased (+0.2%) to 86.319% when pullingd0f333e on bnavigator:discrete-margins into2d7aad0 on python-control:master.

@bnavigator
Copy link
ContributorAuthor

I think this should go into 0.8.4. It enhances functionality, but does not change the API and it fixes the bug that it returns wrong results with discrete input.

sawyerbfuller reacted with thumbs up emoji

@bnavigatorbnavigator added this to the0.8.4 milestoneNov 19, 2020
@bnavigatorbnavigator merged commite525ff6 intopython-control:masterDec 21, 2020
@bnavigatorbnavigator deleted the discrete-margins branchJanuary 5, 2021 20:13
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@ilaynilaynilayn left review comments

@sawyerbfullersawyerbfullersawyerbfuller approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.8.4
Development

Successfully merging this pull request may close these issues.

control.margin() gives wrong result
4 participants
@bnavigator@coveralls@ilayn@sawyerbfuller

[8]ページ先頭

©2009-2025 Movatter.jp