Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Extend returnScipySignalLTI() to discrete systems#445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

bnavigator
Copy link
Contributor

@bnavigatorbnavigator commentedAug 2, 2020•
edited
Loading

These were not covered by the tests, so I wrote some tests and found out it is not that hard to extend them to discrete systems.

@coveralls
Copy link

coveralls commentedAug 2, 2020•
edited
Loading

Coverage Status

Coverage increased (+0.3%) to 86.618% when pullingd6d77dc on bnavigator:extend-tf2scipylti into26206dc on python-control:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.3%) to 84.489% when pullinga8aa41e on bnavigator:extend-tf2scipylti intod3142ff on python-control:master.

@sawyerbfuller
Copy link
Contributor

Returning a cont-time scipy system when dt=None seems like a reasonable choice (I think in scipy, dt=None actually means cont time).

Copy link
Contributor

@sawyerbfullersawyerbfuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

see comment

@bnavigator
Copy link
ContributorAuthor

Re current CI fail:#456

@bnavigatorbnavigator merged commit51c797e intopython-control:masterDec 29, 2020
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@sawyerbfullersawyerbfullersawyerbfuller approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
0.9.0
Development

Successfully merging this pull request may close these issues.

3 participants
@bnavigator@coveralls@sawyerbfuller
[8]ページ先頭
©2009-2025 Movatter.jp