- Notifications
You must be signed in to change notification settings - Fork441
do not override squeeze parameter in forced_response#442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation
coveralls commentedJul 31, 2020 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
coveralls commentedJul 31, 2020
@murrayrm, this is a fix but it changes user facing behavior. I am not sure whether it should go to 0.8.4 or 0.9 |
I think we could argue that this sort of fix is OK in 0.8.4, given that it probably wasn't really used much (since nobody complained that it was broken). |
Yes, looking at git blame, the squeeze parameter was introduced into master by#295 last year and only existed in 0.8.3 since January. No |
Any objections to merge now? |
OK by me. |
Excercising my newly received privileges then. Thanks for adding me to the team 😃 |
squeeze=Falsedoes not work forforced_response()because the parameter is unnecessarily overridden by a shortcut alias to np.squeeze.The current code timeresp_test.py advertises to test this, but actually does not. (#438 does now, that's how I stumbled over it.)