NotificationsYou must be signed in to change notification settings
Fork441
Star1.8k

avoid log(0) in automatic timevector calculation#441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

bnavigator merged 1 commit intopython-control:masterfrombnavigator:zero-poles-time-vector

Aug 18, 2020

Merged

avoid log(0) in automatic timevector calculation#441

bnavigator merged 1 commit intopython-control:masterfrombnavigator:zero-poles-time-vector

Aug 18, 2020

Conversation

Copy link

Contributor

bnavigator commentedJul 31, 2020

The current automatic timevector calculation throws a warning when zero valued poles are present.

(Switch off display of whitespace changes for review)

Copy link

coveralls commentedJul 31, 2020•
edited
Loading

Coverage decreased (-0.003%) to 84.212% when pulling920649b on bnavigator:zero-poles-time-vector into76ec2de on python-control:master.

Copy link

Contributor

sawyerbfuller commentedJul 31, 2020 via email

Good catch. Hadn’t thought about testing for that before. S

On Thu, Jul 30, 2020 at 6:47 PM Ben Greiner ***@***.***> wrote: The current automatic timevector calculation throws a warning when zero valued poles are present. (Switch off display of whitespace changes for review) ------------------------------ You can view, comment on, or merge this pull request online at:#441 Commit Summary - no log(0) in automatic timevector calculation File Changes - *M* control/timeresp.py <https://github.com/python-control/python-control/pull/441/files#diff-e216ba2d66c950242b1475a045e3cd33> (83) Patch Links: -https://github.com/python-control/python-control/pull/441.patch -https://github.com/python-control/python-control/pull/441.diff — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#441>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AN74SSIIXBC4JI66UH6NAVDR6IPADANCNFSM4PPDXKGA> .

-- Sawyer FullerAssistant Professor of Mechanical EngineeringAdjunct, Paul G Allen School of Computer ScienceUniversity of Washingtonhttp://faculty.washington.edu/~minster/(Typed with my thumbs)