- Notifications
You must be signed in to change notification settings - Fork441
Modified setup.py and control/__init__.py to match numpy.#38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
I tried to avoid using the _CONTROL_SETUP_ switch like numpybut this was causing some issues for Travis CI. This means forsetup.py test to work we can't do control import * so I had tochange to explicit imports for discrete_test.py.Closespython-control#37.
Looks like there was a build error with Python 3.2 (see Travis CI error below). Will need to look into this before merging. |
It looks like it timed out installing matplotlib, you might just try restarting the build. |
I tried restarting the build and got the same error (build timeout under python 3.2). So seems like something is actually wrong (?). I won't have time to look into this until the weekend, but will hold on merging until we sort things out. |
It looks like master is timing out as well on the 3.2 build. I think that travis ci must have recently put an upper limit on the build time of 50 minutes. We should probably look into using binary wheels at some point to speed up the testing. |
Still seems strange that only the 3.2 build has a problem (versus 2.7 and 3.2). I took a quick look and it looks like we are spending a fair bit of time (15m) installing scipy and smaller amounts (few minutes each) on matplotlib and a few other packages. |
Now that setup.py has changed (and#37 fixed), I believe this is superfluous, so closing this PR. |
I tried to avoid using theCONTROL_SETUP switch like numpy
but this was causing some issues for Travis CI. This means for
setup.py test to work we can't do control import * so I had to
change to explicit imports for discrete_test.py.Closes#37.