- Notifications
You must be signed in to change notification settings - Fork441
Complex matrices#372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Complex matrices#372
Uh oh!
There was an error while loading.Please reload this page.
Conversation
control/tests/statesp_test.py Outdated
| @@ -21,15 +21,15 @@ def setUp(self): | |||
| """Set up a MIMO system to test operations on.""" | |||
| # sys1: 3-states square system (2 inputs x 2 outputs) | |||
| A322 = [[-3., 4., 2.], | |||
| A322 = [[-3j, 4j, 2.], | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Rather than rewrite an existing test to be complex, better to add a new test and leave the old test in place.
control/tests/statesp_test.py Outdated
| @@ -117,20 +117,23 @@ def test_zero_siso(self): | |||
| np.testing.assert_almost_equal(true_z, z) | |||
| @unittest.skipIf(not slycot_check(), "slycot not installed") | |||
| #@unittest.skipIf(not slycot_check(), "slycot not installed") | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Why comment this out? This will probably cause unit tests to fail when slycot is not installed.
PR to start to rewrite tests with complex matrices (issue#371) in a new branch. So far it seems that poles and zeros are calculated OK, but adding/subtracting/multiplying systems fails.
I've also commented out some "skip if slycot not installed"; some of these tests nonetheless run with sylicot uninstalled