- Notifications
You must be signed in to change notification settings - Fork441
Fix slycot link error#353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
coveralls commentedDec 28, 2019 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
coveralls commentedDec 28, 2019
1 similar comment
coveralls commentedDec 28, 2019
This was referencedDec 29, 2019
The Python 3.7 |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR address a problem in the
slycotbuild process (documentedhere) in which buildingslycotfrom source is currently failing. This is related to issue#349 where coveralls was reporting a decrease in coverage (becauseslycotwas not present => some code was not being tested).To fix this, I changed the
.travis.ymlfile to use theconda-forgeversion ofslycotby default. This is probably the better thing to do in any case, since that is how most users are likely to getslycot. I also added two "optional" (allowed to fail) builds that create theslycotpackage from source code, as was originally done. I put in one for python-2.7 (still working) and one for python-3.7 (failing).I didn't squash the commits when I created this PR, but suggest doing that when it is merged.