Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix testMimoW123#320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
murrayrm merged 1 commit intopython-control:masterfrombnavigator:fix-augwtest
Jun 30, 2019
Merged

Conversation

bnavigator
Copy link
Contributor

@bnavigatorbnavigator commentedJun 27, 2019•
edited
Loading

Thisfixes#190

Because thetf(minreal(g-h)) insiso_almost_equal misses to remove all unobservable states inh (=p[i,j]), the transfer function has a higher order and exceeds the numerical limit on some build systems.

Ran into this while trying to build a package for OpenSUSE on their build system. With the patch, the package builds fine

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 82.121% when pulling4ec1678 on bnavigator:fix-augwtest into662e52e on python-control:master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 82.121% when pulling4ec1678 on bnavigator:fix-augwtest into662e52e on python-control:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 82.121% when pulling4ec1678 on bnavigator:fix-augwtest into662e52e on python-control:master.

@murrayrm
Copy link
Member

Fix seems fine. Need to resolve issue#321 before merging into master to avoid breaking CI tests.

@murrayrmmurrayrm reopened thisJun 30, 2019
@murrayrmmurrayrm merged commit1de184e intopython-control:masterJun 30, 2019
@bnavigatorbnavigator deleted the fix-augwtest branchJuly 1, 2019 08:19
@murrayrmmurrayrm added this to the0.8.3 milestoneJan 4, 2020
murrayrm pushed a commit that referenced this pull requestJan 5, 2020
PR#314 duplicates a lot of code in the test cases by introducing *_array_test.py files. Thus issue#190 addressed in PR#320 resurfaces and needs to be introduced to robust_array_test.pyas well.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.8.3
Development

Successfully merging this pull request may close these issues.

testMimoW123 fails when compiled from source
3 participants
@bnavigator@coveralls@murrayrm
[8]ページ先頭
©2009-2025 Movatter.jp