Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Performance improvements to _remove_useless_states routine in statesp.py#248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

adm78
Copy link
Contributor

  • avoid looping through states
  • significant performance improvement in the creation of large state space models

@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 78.944% when pulling394fa27 on adm78:statesp-performance-improvements into4b0101c on python-control:master.

@coveralls
Copy link

coveralls commentedDec 12, 2018•
edited
Loading

Coverage Status

Coverage decreased (-13.1%) to 65.281% when pullingbe53eb7 on adm78:statesp-performance-improvements into31e6944 on python-control:master.

@adm78
Copy link
ContributorAuthor

Please let me know if you require any modifications to this PR. It would be great to get it merged into the master branch soon.

@repagh
Copy link
Member

Is np.concatenate correct? You could end up with states that are removed for both reasons.
Maybe use np.union1d?
It seems to work now, but that relies on np.delete graciously accepting the indexes specified twice.

…tes methodThis ensures that all elements in the array of state indices to be removed are unique.
@adm78
Copy link
ContributorAuthor

I'm not sure it's possible but I've replaced the np.concatenate with np.union1d just to be safe.

Looks like some of the tests are failing due to slycot import errors...

@murrayrm
Copy link
Member

Travis CI tests are fixed in PR#280. Will merge that into master and then ask pending PRs to merge the change so that we can be sure things are working.

adm78 reacted with thumbs up emoji

@murrayrmmurrayrm added this to the0.8.2 milestoneApr 7, 2019
@murrayrmmurrayrm merged commit5d680f5 intopython-control:masterApr 7, 2019
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.8.2
Development

Successfully merging this pull request may close these issues.

4 participants
@adm78@coveralls@repagh@murrayrm
[8]ページ先頭
©2009-2025 Movatter.jp