Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Fix pzmap not showing zeroes#230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
geez0x1 wants to merge1 commit intopython-control:masterfromgeez0x1:master

Conversation

geez0x1
Copy link

@geez0x1geez0x1 commentedJul 27, 2018•
edited
Loading

pzmap does not show the transfer function's zeroes, as the internal plotting argument hasfacecolors='none':

   if len(zeros) > 0:        plt.scatter(real(zeros), imag(zeros), s=50, marker='o',                    facecolors='none')

Removing this argument solves the issue.

@geez0x1
Copy link
Author

geez0x1 commentedJul 27, 2018•
edited
Loading

Demonstration of the fix:

screenshot from 2018-07-27 17-12-02

@coveralls
Copy link

coveralls commentedJul 27, 2018•
edited
Loading

Coverage Status

Coverage remained the same at 78.914% when pulling278524e on geez0x1:master intoa007fcc on python-control:master.

@murrayrm
Copy link
Member

This is also addressed in PR#193, which is waiting on some changes before being merged. Need to reconcile any differences.

@murrayrmmurrayrm added this to the0.8.2 milestoneJul 27, 2018
@geez0x1
Copy link
Author

Ah, sorry about that, I tried searching for an issue referencing pzmap but couldn't find it. Thanks!

@murrayrm
Copy link
Member

Fixed in PR#193.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.8.2
Development

Successfully merging this pull request may close these issues.

3 participants
@geez0x1@coveralls@murrayrm
[8]ページ先頭
©2009-2025 Movatter.jp